-
Notifications
You must be signed in to change notification settings - Fork 29
GCP WIF impersonation (LibSFC) #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+478
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4db9f9a to
3ffbf04
Compare
3ffbf04 to
40eca7e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
==========================================
- Coverage 79.51% 78.85% -0.66%
==========================================
Files 127 127
Lines 10870 11016 +146
==========================================
+ Hits 8643 8687 +44
- Misses 2227 2329 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 24, 2025
40eca7e to
74ab524
Compare
sfc-gh-pbulawa
requested changes
Nov 25, 2025
74ab524 to
1beee8f
Compare
1beee8f to
ef0701c
Compare
sfc-gh-makowalski
approved these changes
Dec 2, 2025
sfc-gh-pbulawa
approved these changes
Dec 3, 2025
ef0701c to
a94be01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-2236576 | SNOW-2236579: Transitive service account impersonation
Added support for service account impersonation using comma separated delegation chain for GCP.
The change was based off logic in JDBC equivalent and tested using unit tests with a mock HTTP client.
Depends on #950